-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error messages with program-capture device wires and shot vectors #7130
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7130 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 509 509
Lines 49599 49599
=======================================
Hits 49414 49414
Misses 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@albi3ro are we missing tests here since the CI doesn't fail? 😅 |
I often just check for part of the message instead of the full thing. Error messages can sometimes get long, and we just want to check with enough detail to know it's error we wanted.
|
@albi3ro thanks! makes sense :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.