Fix controlled qubit unitary usage #1310
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Do not merge until PL updated |
10 tasks
|
The PR to deprecate |
JerryChen97
commented
Jan 31, 2025
JerryChen97
commented
Jan 31, 2025
JerryChen97
commented
Jan 31, 2025
JerryChen97
added a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Jan 31, 2025
**Context:** We are in favor of `wires`, just like what we did with `MultiControlledX`. !Note: this involves a big user-interface change. With PL version <=0.40, for ControlledQubitUnitary, we have arg wires to be the target_wires, and the arg control_wires is a positional arg. To be consistent with all the other interfaces, we would like to alter this into wires to be positional and to represent control_wires+target_wires Before: ```python mat = np.eye(2) control_wires = [0] wires = [1] ControlledQubitUnitary(mat, control_wires, wires=wires, control_values=...) ``` After: ```python mat = np.eye(2) wires = [0, 1] ControlledQubitUnitary(mat, wires, control_values=...) ``` where the new `wires` should be the concatenate of old `control_wires` and `wires` **Description of the Change:** Besides the modified test files across the whole codebase involving `ControlledQubitUnitary`, we made the following necessary adjustments beyond the `__init__` method: - classmethod `_unflatten`, `_primitive_bind_call` and method `_controlled` were adjusted accordingly following the new interface - move the `TypeError` regarding empty arg `wires` to the beginning. - add a register for `ControlledQubitUnitary` in `bind_new_parameters.py` following the pattern of `CRX` - modified the direct calls of `ControlledQubitUnitary` inside src files `metric_tensor.py`, `controlled.py` and `matrix_ops.py`. ### **Eco-System** This is an inevitable breaking change, so we need to immediately inform the affected repos that depend on latest PennyLane but only apply corresponding changes after this PR gets merged. - [ ] labs - [ ] Catalyst: [frontend/test/pytest/device/test_decomposition.py](https://github.com/PennyLaneAI/catalyst/blob/286e51910a39c55130de8c1c6a806818a2bcb14b/frontend/test/pytest/device/test_decomposition.py#L52) PennyLaneAI/catalyst#1483 - [ ] Lightning: PR to fix it PennyLaneAI/pennylane-lightning#1047 - - [test_gates.py](https://github.com/PennyLaneAI/pennylane-lightning/blob/290c986e7d087e17dbf3f09c6d2dfc8bd738cc08/tests/test_gates.py#L451) - - [test_gates_and_expval.py](https://github.com/PennyLaneAI/pennylane-lightning/blob/290c986e7d087e17dbf3f09c6d2dfc8bd738cc08/tests/lightning_tensor/test_gates_and_expval.py#L72) - - [test_measurements_class.py](https://github.com/PennyLaneAI/pennylane-lightning/blob/290c986e7d087e17dbf3f09c6d2dfc8bd738cc08/tests/lightning_qubit/test_measurements_class.py#L814) - [ ] QML Demos: [tutorial_classically_boosted_vqe.py](https://github.com/PennyLaneAI/qml/blob/c444cec6201338056304d9d5a293f969a3aeec5e/demonstrations/tutorial_classically_boosted_vqe.py#L451); PR to fix it PennyLaneAI/qml#1310 ### **Plugins** - [x] Pennylane-AQT: No instances of deprecated code found. - [x] Pennylane-Qiskit: No instances of deprecated code found. - [x] Pennylane-IonQ: No instances of deprecated code found. - [x] Pennylane-Qrack: No instances of deprecated code found. - [x] Pennylane-Cirq: No instances of deprecated code found. - [x] Pennylane-Qulacs: No instances of deprecated code found. **Benefits:** Unified interfaces with other controlled ops. **Possible Drawbacks:** This is a hard change to deprecate this arg. Would have to introduce errors for testing matrices. **Related GitHub Issues:** [sc-80842] --------- Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Astral Cai <[email protected]>
JerryChen97
added
ci:build-all-qml-demos
|
@Alex-Preciado The jax tutorial (not involved in this PR) in |
|
From PLcore standup 3 Feb 2025, we still need to convert base-branch back to |
|
On the modifications I made in this PR, do we have any concerns from product? @isaacdevlugt For example, I'm not sure if writing it like |
isaacdevlugt
approved these changes
Feb 3, 2025
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Adjust interface of
ControlledQubitUnitaryto be compatible with PennyLane v0.41Summary:
changed 5 occurences in demonstrations/tutorial_classically_boosted_vqe.py and demonstrations/tutorial_testing_symmetry.py
Related Shortcut Stories:
[sc-80842]