Fixes #2 #3
Open
Fixes #2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pentadrago
requested changes
Jan 2, 2018
There was a problem hiding this comment.
Thank you for the pull request.
This commit contains two changes I don't agree with:
- The idea plugin is disliked by the Jetbrains People because it uses the old and somehow deprecated configuration format. I'd like to keep IDE stuff from this project and rely on the import functions of the IDEs.
- Why did you delete the WarInitializer? This enabled the deployment onto an app server.
Best regards,
Steven
|
Regarding your second question: i've deleted it since it (resp. the used interface) is deprecated in the newer spring versions (cf. https://stackoverflow.com/questions/38843015/spring-boot-springbootservletinitializer-is-deprecated). But you're correct mentioning that i should have looked for a solution working with the newer spring version instead of deleting it altogether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added the gradle wrapper files so that a new user don't has to download and install gradle...