Skip to content

Commit

Permalink
Some remaining details to Merge branch 'main' into fix/allow-param-de…
Browse files Browse the repository at this point in the history
…faults
  • Loading branch information
Kolja Waschk committed Jan 17, 2025
1 parent ae2c63c commit f487320
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/pf_driver/src/pf/pfsdp_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ void PFSDPBase::request_handle_tcp(int port)
param_vector_type query;
if (!config_->packet_type.empty())
{
query.push_back(KV("packet_type", packet_type));
query.push_back(KV("packet_type", config_->packet_type));
}
if (port != 0)
{
Expand All @@ -271,7 +271,7 @@ void PFSDPBase::request_handle_tcp(int port)
info_->actual_port = parser_utils::to_long(resp["port"]);
}

void PFSDPBase::request_handle_udp(const std::string& packet_type)
void PFSDPBase::request_handle_udp()
{
param_vector_type query = { KV("address", info_->endpoint), KV("port", info_->actual_port) };
if (!config_->packet_type.empty())
Expand Down
1 change: 1 addition & 0 deletions src/pf_driver/src/ros/ros_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ int main(int argc, char* argv[])
std::string device;
std::string transport_str;
std::string scanner_ip;
int port = 0; /* 0 means: automatic */
std::string topic("/scan");
std::string frame_id("scanner_link");
std::string packet_type; /* empty means: use scanner default */
Expand Down

0 comments on commit f487320

Please sign in to comment.