"port" parameter should be handled as integer, not string #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in
fix/port-is-integerlet the driver and its components handle the TCP/UDP port as an integer, not string as before, thus avoiding irritations about the data type when preparing a*.yamlto configure the sensor and later on.The change affects both the externally visible driver parameter "port" (to specify a fixed port instead of leaving the choice to the sensor or OS) and its internal representation in multiple places.-
Note that existing
*.yamlconfiguration files and applications that expect the ROS parameter "port" to be a string would become incompatible with the updated driver, but I updating them should be trivial. I guess that applications where a specific port really needs to be set are not that many.