Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Porting to ROS2 #82

Closed
wants to merge 8 commits into from
Closed

[WIP] Porting to ROS2 #82

wants to merge 8 commits into from

Conversation

hsd-dev
Copy link
Contributor

@hsd-dev hsd-dev commented Jun 7, 2022

  • CI
  • pf_interfaces
    • package.xml and CMakeLists.txt
  • pf_description
    • package.xml and CMakeLists.txt
    • launch files
  • pf_driver
    • package.xml and CMakeLists.txt

@hsd-dev hsd-dev mentioned this pull request Jun 7, 2022
@hsd-dev
Copy link
Contributor Author

hsd-dev commented Jun 8, 2022

@wawanbreton I have added a very basic TODOs to the main description of the PR. Feel free to add to the list. Also let's try to make sure that the commits are created according to the list (e.g. one commit to port the package.xml and CMakeLists.txt)

@hsd-dev
Copy link
Contributor Author

hsd-dev commented Jun 8, 2022

@wawanbreton do you see a checkbox on this page that says

Allow edits from maintainers

If yes, please check that box.

@wawanbreton
Copy link

Nice, I will take some time to update the TODO list.
I don't see the checkbox you mention, maybe it is on the branch page ? I will take a look.

@wawanbreton
Copy link

Actually, it seems that I have no right on this PR, as you are its author. So I can't see how to edit the description, neither to give you the commit permission. Sorry I'm quite new with workflows on Github !

@hsd-dev hsd-dev changed the title Porting to ROS2 [WIP] Porting to ROS2 Jun 8, 2022
@hsd-dev
Copy link
Contributor Author

hsd-dev commented Jun 9, 2022

@wawanbreton can you try to push your commits to #83? I could not find a solution to push to this PR.

@hsd-dev hsd-dev mentioned this pull request Jun 9, 2022
14 tasks
@hsd-dev
Copy link
Contributor Author

hsd-dev commented Jun 9, 2022

closing in favour of #83

@hsd-dev hsd-dev closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants