Code

[WIP] Porting ros2#83

Code

Closed

hsd-dev wants to merge 194 commits intofoxy-develPepperlFuchs/pf_lidar_ros_driver:foxy-develfrom porting-ros2PepperlFuchs/pf_lidar_ros_driver:porting-ros2Copy head branch name to clipboard

+4,996-2,725

Commits

Commits on May 11, 2022

• rename publisher classes since R2300 could also be single layered

  hsd-dev

  committed
  9d7953a

• parameterize number of layers since it could vary for future versions

  hsd-dev

  committed
  6efadc6

• data publisher differs for R2300 based on device_family parameter

  hsd-dev

  committed
  04cce69

• apply clang-tidy formatting

  hsd-dev

  committed
  cee5aef

• re-arrange functions

  hsd-dev

  committed
  ddefccc

• fix device_family incorrect

  hsd-dev

  committed
  9daaae4

• get device part number

  Show description for f9466a0
  hsd-dev

  committed
  f9466a0

• define correction params for the available device

  hsd-dev

  committed
  f1bfa71

• [WIP] apply correction function to the pointcloud

  Show description for 1b9bf78
  hsd-dev

  committed
  1b9bf78

• apply clang-tidy formatting

  hsd-dev

  committed
  10d3f59

• correct implementation of the correction functions

  hsd-dev

  committed
  138f325

• no need to transform individual clouds since apply_correction does the job

  hsd-dev

  committed
  8988846

Commits on May 12, 2022

• do not publish laserscan data for PointcloudPublisher

  Show description for e192bd8
  hsd-dev

  committed
  e192bd8

Commits on Jun 22, 2022

• custom project laser function including correction calculations

  hsd-dev

  committed
  6dfcc3d

• map quadratic equation coefficients with inclination angle

  hsd-dev

  committed
  6c513de

• recognize device based on device_family

  hsd-dev

  committed
  a47fe7b

• fix get_parameter device family

  hsd-dev

  committed
  15b1788

• apply correction as ROS param

  hsd-dev

  committed
  9507b0c

Commits on Jun 23, 2022

• fix product string

  hsd-dev

  committed
  30231aa

Commits on Jun 24, 2022

• projectLaser from laser_geometry already calculates x,y

  hsd-dev

  committed
  52a92e8

• changed coefficients to radians

  hsd-dev

  committed
  129d93a

• combine calculations for correction on and off

  hsd-dev

  committed
  a834471

• publish laser scans and transform when no correction

  hsd-dev

  committed
  eb67a2d

• call project_laser when correction is on

  hsd-dev

  committed
  29b882c

• Merge pull request #77 from PepperlFuchs/correction_func

  Show description for 21cb7ac
  ptruka

  authored
  21cb7ac

Commits on Jul 7, 2022

• close reader and writer only on terminate to avoid getting called twice

  hsd-dev

  committed
  443b36c

• detect and handle connection failure

  hsd-dev

  committed
  56cd8e9

• add async read with timeout to avoid blocking calls

  hsd-dev

  committed
  6ec03cd

• clang tidy

  hsd-dev

  committed
  3c4032a

• print timeout message only if success

  hsd-dev

  committed
  fc25073

Commits on Jul 11, 2022

• remove std outs

  hsd-dev

  committed
  897dedd

• read_result always exists

  hsd-dev

  committed
  3c2e889

• release handle at init and at shutdown

  hsd-dev

  committed
  2cc0264

• implement reconnectivity with conditional variable

  hsd-dev

  committed
  f370db7

• reduce timeout for no packets received

  hsd-dev

  committed
  af7b874

• fix clang

  hsd-dev

  committed
  0fe2dfe

• move function to cpp file

  hsd-dev

  committed
  8e5fe92

• implement async read for TCP

  hsd-dev

  committed
  7d4d1e6

• handle TCP connect failure

  hsd-dev

  committed
  97bc652

• let device provide the port number always

  hsd-dev

  committed
  acd95ea

• fix clang

  hsd-dev

  committed
  00f9a05

• to enable intensity information

  hsd-dev

  committed
  88843d3

• Merge pull request #81 from PepperlFuchs/reconnectivity

  Show description for c91bc72
  ptruka

  authored
  c91bc72

• causes publish freq to drop at higher scan frequencies and max samples per scan

  Show description for 1c7b535
  hsd-dev

  committed
  1c7b535

Commits on Jul 12, 2022

• Merge pull request #85 from PepperlFuchs/fix_uhd_perf

  Show description for b07c617
  ptruka

  authored
  b07c617

Commits on Aug 13, 2022

• remove mutex

  Show description for 2e52065
  hsd-dev

  committed
  2e52065

• Merge branch 'main' into fix_deadlock

  hsd-dev

  authored
  5e1f3fa

Commits on Nov 28, 2022

• Merge pull request #86 from PepperlFuchs/fix_deadlock

  Show description for fc9a38b
  ptruka

  authored
  fc9a38b

Commits on Nov 29, 2022

• Moved sources to src folder

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  e69dc64

• Splitted headers to have a single class by file

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  dfd88a2

• Splitted existing cpp files to match headers

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  a71bca7

• Added cpp files for each header when possible

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  4ad0d0e

• Code cleaning and minor optimizations

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  dc35985

• Applied clang formatting

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  65746ce

• Fixed missing include

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  d805033

• remove references to mutex after refactoring

  hsd-dev

  committed
  8410053

• header only has function declaration

  hsd-dev

  committed
  5a02ecc

• apply clang formatting

  hsd-dev

  committed
  54927bf

Commits on Jan 9, 2023

• Merge pull request #87 from wawanbreton/code_refactoring

  Show description for 62cbc5c
  ptruka

  authored
  62cbc5c

Commits on Jan 23, 2023

• utilize port specified in config for UDP connection

  hsd-dev

  committed
  71ef859

Commits on Jan 26, 2023

• Merge pull request #99 from PepperlFuchs/fix_udp_port

  Show description for 067eb47
  hsd-dev

  authored
  067eb47

• Allow to set hmi_application_bitmap

  MichaelGrupp

  committed
  9a75cde

• Allow to disable RViz & pf_bringup in launch file.

  Show description for 3ccad3d
  MichaelGrupp

  committed
  3ccad3d

• Merge pull request #93 from MichaelGrupp/launch-args

  Show description for c0c2ffe
  hsd-dev

  authored
  c0c2ffe

• Merge branch 'main' into application_bitmap

  hsd-dev

  authored
  1d9e8bd

• Merge pull request #94 from MichaelGrupp/application_bitmap

  Show description for 99617c7
  hsd-dev

  authored
  99617c7

Commits on Jan 30, 2023

• port is optional

  hsd-dev

  committed
  bc67755

• default packet type is C

  hsd-dev

  committed
  5d8bbe2

• add config files for R2300 device family 7 (single layer)

  hsd-dev

  committed
  57437e2

• Merge branch 'main' into r2300_single_layer

  hsd-dev

  authored
  ae9590d

• Merge pull request #101 from PepperlFuchs/r2300_single_layer

  Show description for 4899240
  ptruka

  authored
  4899240

Commits on Jan 31, 2023

• Update r2300.launch

  Show description for aebe0a1
  ptruka

  authored
  aebe0a1

Commits on Feb 22, 2023

• safe feed time within the defined timeout

  hsd-dev

  committed
  f6d0093

Commits on Feb 23, 2023

• Move stamping close to data reading.

  Show description for 0b84595
  

  ValerioMagnago

  authored and

  hsd-dev

  committed
  0b84595

• Fixes type of port parameter in cfg files

  Show description for 069f271
  

  Kai Franke

  authored and

  hsd-dev

  committed
  069f271

• Clean termination of ros_main node.

  Show description for 6c1820f
  

  ValerioMagnago

  authored and

  hsd-dev

  committed
  6c1820f

• apply clang

  hsd-dev

  committed
  4aa5b46

• Merge pull request #109 from PepperlFuchs/safe_feed_time

  Show description for b66d106
  ptruka

  authored
  b66d106

• Merge pull request #104 from ValerioMa/main

  Show description for ffbc656
  ptruka

  authored
  ffbc656

• Merge pull request #106 from kalectro/main

  Show description for 54361bb
  ptruka

  authored
  54361bb

• Merge pull request #108 from ValerioMa/terminate_cleanly

  Show description for 0b5870d
  ptruka

  authored
  0b5870d

Commits on Feb 28, 2023

• Basically working version of ROS2 porting.

  Show description for acc0356
  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  acc0356

• Cleaning

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  2189d08

• basic porting of description package - builds

  hsd-dev

  committed
  a540f16

• port bringup launch

  hsd-dev

  committed
  8329003

• bringup rviz

  Show description for 13cbcf6
  hsd-dev

  committed
  13cbcf6

• update CI for ROS2

  hsd-dev

  committed
  f976782

• fix clang tidy

  hsd-dev

  committed
  9f6e1e8

• add deps

  hsd-dev

  committed
  1e39bd9

• remove humble from CI

  hsd-dev

  committed
  193b893

• add dep to interfaces

  hsd-dev

  committed
  72e983c

• update build and usage instructions and CI badge

  hsd-dev

  committed
  fe36269

• Basically working version of ROS2 porting.

  Show description for 4634bde
  hsd-dev

  committed
  4634bde

• Removed missing install directory

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  41840b9

• Fixed pf_interface build on foxy

  

  Erwan MATHIEU

  authored and

  hsd-dev

  committed
  426718c

• move interfaces package to src folder

  hsd-dev

  committed
  9a0adcd

• apply clang

  hsd-dev

  committed
  c4e4217

• create new package for interfaces

  hsd-dev

  committed
  4f38190

• port header message serialization

  hsd-dev

  committed
  6a65c82

• apply clang

  hsd-dev

  committed
  68b1772

• apply clang

  hsd-dev

  committed
  232ec1c

• remove references to dynamic reconfigure

  hsd-dev

  committed
  e8e72fb

• update message signatures and headers

  hsd-dev

  committed
  b6c055f

Commits on Mar 1, 2023

• port nodes and interfaces to ROS2

  hsd-dev

  committed
  e053b17

• update message signatures

  hsd-dev

  committed
  719d583

• fix rebase and update ROS 2 interfaces

  hsd-dev

  committed
  2bd4f19

• fix c++ includes

  hsd-dev

  committed
  78ab889

• add pf_interfaces to CMakeLists

  hsd-dev

  committed
  cac08b4

• apply clang

  hsd-dev

  committed
  811889c

• apply clang

  hsd-dev

  committed
  65a448d

• replace dynamic reconf params with ROS 2 params

  hsd-dev

  committed
  acdbe1f

• use yaml-cpp to read nested params from yaml file

  Show description for 9552650
  hsd-dev

  committed
  9552650

• fix clang

  hsd-dev

  committed
  80ebf3e

• fix clang

  hsd-dev

  committed
  f42633e

• add empty default value to parameter to support foxy

  hsd-dev

  committed
  e655c5a

• always chooses v6 for some reason. explicitly forcing to choose v4

  Show description for d55c419
  hsd-dev

  committed
  d55c419

• declare params of different types

  hsd-dev

  committed
  fd55c88

• de-serialize buffer ROS 2 style

  hsd-dev

  committed
  2432698

• convert sec to milisec

  hsd-dev

  committed
  a902826

• fix rebasing issues

  hsd-dev

  committed
  ef8dd3b

Commits on Mar 27, 2023

• use memcpy to parse buffer to header message

  hsd-dev

  committed
  78e04ed

• port time now to ros 2

  hsd-dev

  committed
  48e6bfa

• port launch files

  hsd-dev

  committed
  a8ca53a

• fix clang

  hsd-dev

  committed
  ff6a527

Commits on Mar 30, 2023

• create var for project sources

  hsd-dev

  committed
  56bcb0a

• add empty gtest

  hsd-dev

  committed
  be21ebb

• add test to parse R2000 packet of type C - test fails currently

  hsd-dev

  committed
  24760a7

• fix clang

  hsd-dev

  committed
  88debaa

• remove linting tests

  hsd-dev

  committed
  09762a5

• update parser test to read dump

  hsd-dev

  committed
  d61f7fb

• fix clang

  hsd-dev

  committed
  2e69daa

Commits on Mar 31, 2023

• add gtest to test pipeline by reading dump

  Show description for 2991643
  hsd-dev

  committed
  2991643

• update test to keep reader in scope

  hsd-dev

  committed
  5ccf23d

• dump more data

  hsd-dev

  committed
  a6b07c4

• create tests folder in include

  hsd-dev

  committed
  e8a979d

• use RCLCPP_INFO instead of cout

  hsd-dev

  committed
  8ff989f

• add tcp server to the test

  hsd-dev

  committed
  a316908

Commits on Apr 2, 2023

• memcpy fields individually

  Show description for 6eee713
  hsd-dev

  committed
  6eee713

• causes bad_weak_ptr

  hsd-dev

  committed
  5208b3f

• removed debug print

  hsd-dev

  committed
  9a6c151

• memcpy r2300 header fields individually

  hsd-dev

  committed
  f2284fd

• dict way of declaring params not working

  hsd-dev

  committed
  f09884c

• fix params yaml ros 2 style

  hsd-dev

  committed
  bc39a2f

• fix clang

  hsd-dev

  committed
  88bc96b

Commits on Apr 11, 2023

• use RCPCPP logging instead of std::cout

  hsd-dev

  committed
  2801e7d

• spin node

  Show description for 7a39780
  hsd-dev

  committed
  7a39780

• update rviz config

  hsd-dev

  committed
  f825f3a

• use global node for PF data publishers

  hsd-dev

  committed
  9838cd8

• fix clang

  hsd-dev

  committed
  de84a80

Commits on Apr 13, 2023

• viz scanner model in rviz

  hsd-dev

  committed
  1640b49

• include xacro in r2300 launch

  hsd-dev

  committed
  becd16f

Commits on May 23, 2023

• calculate scan params after init

  hsd-dev

  committed
  6b22563

Commits on May 24, 2023

• fix readme

  hsd-dev

  committed
  2aa06d4

• fix readme

  hsd-dev

  committed
  9569f18

• update r2300 rviz config

  hsd-dev

  committed
  4cef537

• fix r2300 launch and yaml

  hsd-dev

  committed
  ecaf7c7

Commits on May 26, 2023

• fix watchdogtimeout value for r2300

  hsd-dev

  committed
  f30b3d6

Commits on Jul 10, 2023

• fix reconnect crash

  hsd-dev

  committed
  4b040f8

• start watchdog timer only if the device is R2000

  hsd-dev

  committed
  5b05b4f

• add missing params for R2300

  hsd-dev

  committed
  44a1f61

Commits on Jul 11, 2023

• fix param set failure

  hsd-dev

  committed
  38efecd

• add missing params

  hsd-dev

  committed
  94332b7

Commits on Aug 14, 2023

• foxy is already eol

  hsd-dev

  committed
  94351b6

• TimePanel display is not available in Foxy

  hsd-dev

  committed
  d5b363f

• fix get product string

  hsd-dev

  committed
  f5f6c76

• add single layer launch file

  hsd-dev

  committed
  1f203a1

• implement missing params

  hsd-dev

  committed
  bd05911

Commits on Aug 16, 2023

• scan_frequency is already declared in pfsdp_base

  hsd-dev

  committed
  537b316

• params defined in ros_main

  hsd-dev

  committed
  6152665

• fix double declaration of params

  hsd-dev

  committed
  15c98ba

• causes reclaration of param error

  Show description for 056e9c1
  hsd-dev

  committed
  056e9c1

Commits on Oct 20, 2023

• set parameter set callback in derived classes

  hsd-dev

  committed
  77b4f4e

• fix parameters wih on/off values

  hsd-dev

  committed
  3124192

• fkix formatting

  hsd-dev

  committed
  3f9db13

• undefined behaviour when destroying any derived packet

  Show description for f96eba6
  hsd-dev

  committed
  f96eba6

• fix ParameterAlreadyDeclaredException during reconnectivity

  hsd-dev

  committed
  ca7f7b9

• add nanoseconds value -- only warning for foxy / galactic, but error for humble

  hsd-dev

  committed
  46ca683

Commits on Oct 22, 2023

• fix error with finding jsoncpp lib

  Show description for 4519b35
  hsd-dev

  committed
  4519b35

• add humble and iron to industrial_ci

  hsd-dev

  committed
  5f68f20

Commits on Oct 23, 2023

• samples_per_scan is of type int

  hsd-dev

  committed
  eadb75d

• return success of set_parameter

  hsd-dev

  committed
  dffc57d

• fix more parameters with on/off values

  hsd-dev

  committed
  ed53919

• fix clang

  hsd-dev

  committed
  55b60e7

• fixes for r2300 single layer

  hsd-dev

  committed
  f44648c

• rviz config is defined in description package

  hsd-dev

  committed
  281ac85

Commits on Oct 24, 2023

• add .gitignore

  hsd-dev

  committed
  779b736

• fix rviz config for single layer

  hsd-dev

  committed
  bb28b78

Commits on Oct 25, 2023

• fix again rviz config for single layer

  hsd-dev

  committed
  837b72e

Commits on Oct 27, 2023

• handle sigint to stop transmission and release handle

  hsd-dev

  committed
  770d69c

Commits on Nov 8, 2023

• change build to cmake

  hsd-dev

  committed
  30ef9db

• driver has been tested for humble

  hsd-dev

  committed
  242b902

• update tests to launch_testing

  hsd-dev

  committed
  269456a

• fix launch_testing dep

  hsd-dev

  committed
  4609e74

• add missing deps

  hsd-dev

  committed
  0bceaa3