Reworked storage configuration section - added storage URI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way how storage backend is configured: instead of 'type' and 'path' parameters we now have single 'uri', which incorporates both and is open for future extensions Currently, two schemas are supported: * 'file://<path>' for local filesystem; * 's3://<access_key_id>:<secret_access_key>@<bucket_name>/<path>' for AWS S3. Please note that for 's3' credentials can be omitted, in other words 's3://<bucket_name>/<path>' is also a valid URI provided that this <bucket_name> bucket is publicly accessible. 's3_storage_backend' class (still a stub) extended with missing AWS S3 configuration parameters: * 'access_key_id'; * 'secret_access_key'; * 'bucket'. Reworked constructors of both 's3_storage_backend' and 'filesystem_storage_backend': they now accept single 'boost::urls::url_view_base' parameter. These constructors extended with basic URI validation (for schema, userinfo, host, port, path, query, and fragment). 'do_get_description()' method of both 's3_storage_backend' and 'filesystem_storage_backend' extended with including more configuration parameters: * 'path' for local filesystem; * 'bucket' and 'path' for AWS S3 (credentials are omitted deliberately). Reworked 'storage_backend_factory::create()' method: it now determines which concrete implementation of the 'basic_storage_backend' interface it should construct based on the schema part of the 'uri' parameter from the 'storage' configuration section. Update "help" message for the main application to reflect new 'storage.uri' parameter. Updated sample configuration JSON file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way how storage backend is configured: instead of 'type' and 'path' parameters we now have single 'uri', which incorporates both and is open for future extensions
Currently, two schemas are supported:
's3_storage_backend' class (still a stub) extended with missing AWS S3 configuration parameters:
Reworked constructors of both 's3_storage_backend' and 'filesystem_storage_backend': they now accept single 'boost::urls::url_view_base' parameter. These constructors extended with basic URI validation (for schema, userinfo, host, port, path, query, and fragment).
'do_get_description()' method of both 's3_storage_backend' and 'filesystem_storage_backend' extended with including more configuration parameters:
Reworked 'storage_backend_factory::create()' method: it now determines which concrete implementation of the 'basic_storage_backend' interface it should construct based on the schema part of the 'uri' parameter from the 'storage' configuration section.
Update "help" message for the main application to reflect new 'storage.uri' parameter.
Updated sample configuration JSON file.