PMM-13014 pull upstream changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Moudani <[email protected]>
…g-response-entries-with-ext-165 Fix go-openapi#165
Signed-off-by: ChandanChainani <[email protected]>
…r_not_working_with_number Fix `x-order` not working with number value go-openapi#162
According to the json draft 4 (or later) spec, empty schema is equivalent to true. * checked with the OP's test case (spec expansion) * added unit test * fixes go-openapi#148 Signed-off-by: Frederic BIDON <[email protected]>
* re-enacted golangci-lint run in github action * re-enacted codecov uploads in github action Signed-off-by: Frederic BIDON <[email protected]>
* updated linter config * refactored tests: if !assert => require * fixed a few other linting issues other than test code: x := append(y, z...), typos Signed-off-by: Frederic BIDON <[email protected]>
* appveyor used to be our sole CI for windows * this has now been handed over to github actions * removing this config and the need to manage tokens * fixes go-openapi#161 * fixes go-openapi#167 (duplicate) Signed-off-by: Frederic BIDON <[email protected]>
chore: updated linting config, relinted
ci: re-enacted linting
ci: removed deprecated appveyor CI
fixed json unmarshal for BoolOrSchema
* updated minimum go version required to go1.19 (like most other go-openapi repos) * fixed wrong badges/links in README * relinted, removing deprecated stdlib function calls Signed-off-by: Frederic BIDON <[email protected]>
Starting with go1.16 go standard library exposes an embedded FS. Replaced bindata codegen by assets embedded with the standard library. Signed-off-by: Frederic BIDON <[email protected]>
A more thorough investigation on loading specs from a generated server from paths containing special characters (such as blank spaces, parenthesis) did not conclude that it was necessary to alter how cache entries are matched. Indeed, this change deeply altered how keys in the cache are managed and was therefore at best, a risky bet. * reverted commit e8e27ff * added check to ensure that the root pseudo-document is preloaded in cache under all conditions * added more unit tests to check the behavior of the normalizers against escaped characters * closes go-openapi#145 Signed-off-by: Frederic BIDON <[email protected]>
updated go version
Proposal: adopt embedfs
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Every time a job is posted, I receive false alarm failure notifications because of some cache conflict during the linting job. Reference: golangci/golangci-lint-action#807 Signed-off-by: Frederic BIDON <[email protected]>
… resolution when SKipSchema (go-openapi#183) * fix(expand): parameters & responses should properly follow remote doc resolution when SKipSchema * fixes go-openapi#182 * contributes go-swagger/go-swagger#2743 Signed-off-by: Frederic BIDON <[email protected]> * fixed assertion in test for windows paths Signed-off-by: Frederic BIDON <[email protected]> --------- Signed-off-by: Frederic BIDON <[email protected]>
These discussion threads are valuable, but no longer active. * fixes go-openapi#164 * fixes go-openapi#23 Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frédéric BIDON <[email protected]>
Bumps the go-openapi-dependencies group with 1 update: [github.com/go-openapi/swag](https://github.com/go-openapi/swag). Updates `github.com/go-openapi/swag` from 0.22.6 to 0.22.9 - [Commits](go-openapi/swag@v0.22.6...v0.22.9) --- updated-dependencies: - dependency-name: github.com/go-openapi/swag dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-openapi-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the development-dependencies group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/setup-go](https://github.com/actions/setup-go) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) Updates `actions/setup-go` from 4 to 5 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) Updates `codecov/codecov-action` from 3 to 4 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: development-dependencies - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major dependency-group: development-dependencies - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Frédéric BIDON <[email protected]>
Bumps the development-dependencies group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 3 to 4 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Using paths-ignore as a short-circuit for doc-only PRs does not work: branch protection rules cannot be passed. Signed-off-by: Frederic BIDON <[email protected]>
Bumps the development-dependencies group with 1 update: [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action). Updates `golangci/golangci-lint-action` from 3 to 4 - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v4) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
dependency-type is irrelevant in the gomod ecosystem. This setting prevented some updates to auto-merge as expected. Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.