-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the output of the Perun #174
Conversation
log: add major step information; log: add minor step information; log: add printing of tag.
log: rework warning and error; log: add basic styles; commands/cli: rework output of perun init.
log: reworked the minor_info little; common_kit: fix bug.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #174 +/- ##
==========================================
- Coverage 98.70% 98.68% -0.02%
==========================================
Files 131 131
Lines 8485 8539 +54
==========================================
+ Hits 8375 8427 +52
- Misses 110 112 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
log: rename minor_info_fail to minor_fail; log: rename minor_info_success to minor_success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed my code, and found few errors, which I will fix in next commit.
various: because f*** you codecov patch.
log: I had no idea what it did and why it did it, so I deleted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I like the new logging API and the way you can build the terminal output. I noticed the log messages regarding job progress in one of the screenshots, should we perhaps consider enhancing logging with some terminal progress bar (e.g., think of apt or dnf package managers)?
"""Generates a profile for specified command with init seeds, compares each other. | ||
|
||
TODO: This might need some checking and tweaking as I believe it is quite shady |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's shady about this? Is it something serious? If so, we should probably open a new issue for it so we don't forget about it.
Good point, though not for the particular case, I can see the usage for the "ticks". I will merge this and make an issue out of this. |
This PR: