Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the output of the Perun #174

Merged
merged 25 commits into from
Feb 12, 2024
Merged

Enhance the output of the Perun #174

merged 25 commits into from
Feb 12, 2024

Conversation

tfiedor
Copy link
Collaborator

@tfiedor tfiedor commented Feb 9, 2024

This PR:

  1. Enhances the output on the commandline,
  2. Remodels the way information is given to user,
  3. Extract styling and colours to isolate package.

log: add major step information;
log: add minor step information;
log: add printing of tag.
log: rework warning and error;
log: add basic styles;
commands/cli: rework output of perun init.
log: reworked the minor_info little;
common_kit: fix bug.
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f9620f0) 98.70% compared to head (433379c) 98.68%.

Files Patch % Lines
perun/logic/config_templates.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #174      +/-   ##
==========================================
- Coverage   98.70%   98.68%   -0.02%     
==========================================
  Files         131      131              
  Lines        8485     8539      +54     
==========================================
+ Hits         8375     8427      +52     
- Misses        110      112       +2     
Flag Coverage Δ
coverage-3.10 ?
coverage-3.11 98.68% <99.72%> (+0.03%) ⬆️
coverage-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfiedor tfiedor requested a review from JiriPavela February 12, 2024 12:17
@tfiedor
Copy link
Collaborator Author

tfiedor commented Feb 12, 2024

Preview of the new look:
output-rm
output-add
output-init
output-collect
output-fuzzing

Copy link
Collaborator Author

@tfiedor tfiedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my code, and found few errors, which I will fix in next commit.

various: because f*** you codecov patch.
log: I had no idea what it did and why it did it, so I deleted it.
Copy link
Collaborator

@JiriPavela JiriPavela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I like the new logging API and the way you can build the terminal output. I noticed the log messages regarding job progress in one of the screenshots, should we perhaps consider enhancing logging with some terminal progress bar (e.g., think of apt or dnf package managers)?

"""Generates a profile for specified command with init seeds, compares each other.

TODO: This might need some checking and tweaking as I believe it is quite shady
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's shady about this? Is it something serious? If so, we should probably open a new issue for it so we don't forget about it.

@tfiedor
Copy link
Collaborator Author

tfiedor commented Feb 12, 2024

Great, I like the new logging API and the way you can build the terminal output. I noticed the log messages regarding job progress in one of the screenshots, should we perhaps consider enhancing logging with some terminal progress bar (e.g., think of apt or dnf package managers)?

Good point, though not for the particular case, I can see the usage for the "ticks". I will merge this and make an issue out of this.

@tfiedor tfiedor merged commit 27ac30f into devel Feb 12, 2024
11 of 12 checks passed
@tfiedor tfiedor deleted the enhancing-cli-output branch February 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants