Code style maintenance #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now use newer scipy with its `simpson` integration method.
All dependencies are now bumped to their most recent version that still supports Python 3.9.
tfiedor
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #117 and #126.
Docstrings now shouldn't contain any type annotations that could be in conflict with the inline code annotations (it is possible that some docstring type hints still remain in the codebase - please remove them if you find them).
Pre-commit support for our code formatter Black was added, as well as pre-commit checks for trailing whitespaces and missing end-of-lines.
make devnow installs pre-commit plugins during the setup, so contributors should have it up and running without any additional installation steps (consider re-runningmake devafter this PR is merged).We should consider enabling https://pre-commit.ci/ for the Perun repo, as it will run our pre-commit checks for PRs even if someone opts-out of pre-commit locally. No additional setup should be needed, the usual pre-commit config file is enough, unless we want to change something specifically for PRs.
Please merge this only after #221 is merged.