Add support for importing data from ELK #256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #256 +/- ##
=======================================
Coverage 99.07% 99.08%
=======================================
Files 150 150
Lines 10402 10470 +68
=======================================
+ Hits 10306 10374 +68
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| TODO: the import-dir could be removed by extracting this functionality to command-line callback and massage | ||
| the paths during the CLI parsing; hence assuming that the paths are correct when importing. I think the parameter | ||
| only complicates the code. |
There was a problem hiding this comment.
Just a note: this wouldn't really work, as the import-dir path prefix is also applied to paths that can be found in CSV file(s). Although we could technically parse the files in the callback, it doesn't seem like the proper place to parse files with a bit more complicated format and error checking.
There was a problem hiding this comment.
Would extracting this to config hierarchy work? Have lookup.path, e.g. that would be gathered recursively through runtime, local and shared config and helper function that would resolve the path wrt to this set path? Then --import-dir would simply add to the runtime(), one could add it to local or shared to not have to use import-dir at all.
|
I will merge this, even though I will rework the import to the ELK (not happy with the flattening), but I wish the metadata to be merged already. |
This PR adds support of reading profiles from ELK, which saves the queries in form of
{'queries': [{...}...]}".Also adds support for
metadatakey.