-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Migrate connectivity logic from UI to Connector class #53
MNT: Migrate connectivity logic from UI to Connector class #53
Conversation
David (Windows) and I (Linux) have tested this on three configurations:
Setup 1 works for David but the image and marker update is very slow. It does not work for me however, as the detector is unable to open the USB device. In addition, the GUI is prone to crashing on my machine, which can be caused by:
On my machine I am also not able to load/view calibration images. |
Thanks @keiranbarr and @Rampex1 , this is helpful. I'll try to figure out why you're getting these behaviours. |
As per discussion, it appears as though there are two issues at play here:
I will investigate the second issue, the first will be resolved separately |
Code looks good and works fine for me |
I am getting an error when clicking on preview image in the detector panel. |
Do you have any other information or error text? It is probably worth checking the console/terminal outputs too |
I investigated David's issue above and it doesn't seem to be related to the camera. The Pi at 192.168.0.101 is running the new code while the one at 192.168.0.102 is running the old code. If I power both down and switch SD cards then it switches: the Pi at 192.168.0.102 is unable to detect well, while the one at 192.168.0.101 works fine. I think this is related to getting and setting the default capture parameters of the Pi Cameras, because I had noticed issues before with the capture image being poor by default on the Pi's running the new code. However, I have been unable to visually verify that the image quality is indeed worse, because I cannot preview the image without hanging the GUI. |
In that one capture it looks as though the markers in the middle of the image are generally being captured and the ones around the outside are generally not. I wonder if it's an effect of the lens distortion. We might try undistorting the image before processing it, though that will incur some processing overhead. I'll take a look too to compare the two cameras. I think this work can be merged. Though we may have found a few new issues to investigate.
Though it does still work if you run through VSCode? |
When I run through VSCode, the detector running the old code works as expected, but strangely the detector running the new code causes the GUI to hang when trying to preview image. From bash, connecting to either detector and trying to update the preview causes GUI hang. |
|
|
I believe we figured this was due to a numpy update and is fixed in #51 |
Before trying undistortion, it may be worth trying different values for |
Connectivity buttons have been removed from the various panels, except for the
Connector
panel. TheConnector
panel now allows you to start either "Detectors Only" or "Detectors and Solvers". The state is now expected to persist across transitions between tabs.