-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmp document functions #146
Open
moregan
wants to merge
39
commits into
Perl-Critic:master
Choose a base branch
from
moregan:cmp_document_functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Makefile.PL
Conflicts: t/ppi_statement_sub.t
Conflicts: t/ppi_statement_package.t t/ppi_statement_sub.t t/ppi_token_operator.t
not require that the caller call flush_locations on the document.
Conflicts: t/20_tokenizer_regression.t t/21_exhaustive.t Conflicts: t/20_tokenizer_regression.t t/21_exhaustive.t
Normally I don't like unconditional exports, but thought this might be a case for them. |
Haven't read everything yet, but for tests unconditional exports are fine. :) |
moregan
force-pushed
the
cmp_document_functions
branch
from
December 24, 2014 03:22
efcec28
to
3ee7f21
Compare
wchristian
force-pushed
the
master
branch
4 times, most recently
from
January 20, 2017 20:15
07cd2bb
to
46e810f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add t::lib::PPI::Test::CMP, containing the cmp_document family of testing functions, plus conversion of one .t file to use them. This is the last of the material from the old cmp_document branch. When it is merged, the old pull request #49 can be closed.
Changes since this material was last reviewed: added Class::Name => content shorthand, ability to skip children of an element via NODESCEND.