S_uiv_2buf: code quality improvements suggested in GH#22927

Perl · Jan 19, 2025 · fca15f2 · fca15f2
1 parent f0f3175
commit fca15f2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/sv_inline.h b/sv_inline.h
@@ -1055,14 +1055,13 @@ S_uiv_2buf(char *const buf, const IV iv, UV uv, const int is_uv, char **const pe
     word_ptr = (U16*)ptr;
     word_table = (U16*)Perl_int2str_table.arr;
 
-    if (UNLIKELY(is_uv))
+    if (is_uv)
         sign = 0;
     else if (iv >= 0) {
         uv = iv;
         sign = 0;
     } else {
-        /* Using 0- here to silence bogus warning from MS VC */
-        uv = (UV) (0 - (UV) iv);
+        uv = NEGATE_2UV(iv);
         sign = 1;
     }