util.c: assert that format strings are not empty #22378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of these format strings are empty, things can go very wrong at runtime, from garbage output to segfaults (e.g. see Perl#22375). This is a static check, so it could be placed in any source file. I chose util.c because according to the comment at the top, it is the home of "any stuff that people couldn't think of a better place for".
khwilliamson
approved these changes
Jul 4, 2024
jkeenan
reviewed
Jul 4, 2024
| STATIC_ASSERT_DECL(sizeof NVff > 1); | ||
| STATIC_ASSERT_DECL(sizeof NVgf > 1); | ||
| STATIC_ASSERT_DECL(sizeof Gid_t_f > 1); | ||
| STATIC_ASSERT_DECL(sizeof Uid_t_f > 1); |
There was a problem hiding this comment.
Could these be placed in a loop? Could they be alphabetized?
There was a problem hiding this comment.
Could these be placed in a loop?
No, C doesn't do that kind of metaprogramming.
Could they be alphabetized?
Yes, but the current order matches the order of symbols in config.h. Which would be more useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of these format strings are empty, things can go very wrong at runtime, from garbage output to segfaults (e.g. see #22375).
This is a static check, so it could be placed in any source file. I chose util.c because according to the comment at the top, it is the home of "any stuff that people couldn't think of a better place for".