Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure: Fix compilation error on some systems #22799

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

khwilliamson
Copy link
Contributor

See #22793

This typo in a printf format causes some C compilations to fail; others to just warn. However stderr is redirected to /dev/null, so we weren't aware of this issue.

When it fails, other issues cause perl to not be usable on the system.

This commit should be added to maint 5.40 and 5.38

  • This set of changes requires a perldelta entry, to be furnished

See Perl#22793

This typo in a printf format causes some C compilations to fail; others
to just warn.  However stderr is redirected to /dev/null, so we weren't
aware of this issue.

When it fails, other issues cause perl to not be usable on the system.
@jkeenan
Copy link
Contributor

jkeenan commented Nov 30, 2024

See #22793

This typo in a printf format causes some C compilations to fail; others to just warn. However stderr is redirected to /dev/null, so we weren't aware of this issue.

Do you recall which platforms this was a problem on?

@tonycoz
Copy link
Contributor

tonycoz commented Dec 2, 2024

Do you recall which platforms this was a problem on?

Any system that has the compiler enable -Werror=format by default, though I don't know any that do that. Ubuntu was setting -Werror=format-security but that's different.

In any case it fixes a bug (one that produces undefined behaviour technically).

@jkeenan
Copy link
Contributor

jkeenan commented Dec 2, 2024

This commit should be added to maint 5.40 and 5.38

If so, then before doing those 2 maintenance releases, we should line up some machines on which we can test this patch. (Passes against blead for me.)

@khwilliamson
Copy link
Contributor Author

The OP has tested on their machine running 5.38; and I have tested it on my machine running 5.38

@khwilliamson khwilliamson merged commit c9a9e95 into Perl:blead Dec 4, 2024
34 checks passed
@khwilliamson khwilliamson deleted the musl branch December 4, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants