Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storable: use utf8_to_bytes_overwrite() if available #22956

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open

Storable: use utf8_to_bytes_overwrite() if available #22956

wants to merge 1 commit into from
+19 −1

Conversation

khwilliamson
Copy link
Contributor

This is simpler and saves a malloc each time.

Note that this code could use plain utf8_to_bytes() on older perls, but it is less convenient, so would require more code; I don't think the performance gain is worth it.

  • This set of changes does not require a perldelta entry.

@khwilliamson
Storable: use utf8_to_bytes_overwrite() if available
ac88e7f 
This is simpler and saves a malloc each time.

Note that this code could use plain utf8_to_bytes() on older perls, but
it is less convenient, so would require more code; I don't think the
performance gain is worth it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khwilliamson