Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op.c: don't warn about !!$x == $y #22965

Merged
merged 1 commit into from
Jan 31, 2025
Merged

op.c: don't warn about !!$x == $y #22965

merged 1 commit into from
Jan 31, 2025
+47 −21

Conversation

mauke
Copy link
Contributor

@mauke mauke commented Jan 31, 2025

Exempt !! from the "Possible precedence problem between ! and <cmp>" warning.

Fixes #22954.

  • This set of changes requires a perldelta entry, and it is included.

@mauke
op.c: don't warn about !!$x == $y
ebd0982 
Exempt `!!` from the "Possible precedence problem between ! and <cmp>"
warning.

Fixes Perl#22954.
leonerd
leonerd approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@leonerd leonerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@demerphq
Copy link
Collaborator

demerphq commented Jan 31, 2025 via email

@mauke mauke merged commit 65e079e into Perl:blead Jan 31, 2025
34 checks passed
@mauke mauke deleted the fix-22954-exempt-not-not branch January 31, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonerd leonerd leonerd approved these changes

@jkeenan jkeenan jkeenan approved these changes

@Leont Leont Leont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Possible precedence problem between ! and numeric eq (==)" failure in automake
5 participants
@mauke @demerphq @Leont @jkeenan @leonerd