Attempt to remove deprecated uvuni_to_utf8() #23466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
force-pushed
the
rm_deprecated
branch
from
91be135 to
a026fff
Compare
|
I'm a bit confused as to the status of this pull request. Shouldn't it have been closed when 3afafdb was committed? |
It has been deprecated since 5.32, emitting a compiler warning if actually called (for most modern compilers). I think it is time to see what breaks when we remove it.
khwilliamson
force-pushed
the
rm_deprecated
branch
from
a026fff to
e01bb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deprecated since 5.32, emitting a compiler warning if actually called (for most modern compilers).
I think it is time to see what breaks when we remove it.