Assorted File::stat changes and clean-up #23509
Merged
+146
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grinnz
reviewed
Jul 30, 2025
Grinnz
reviewed
Jul 30, 2025
mauke
force-pushed
the
file-stat-cleanup
branch
2 times, most recently
from
8eaf284 to
895a91f
Compare
Grinnz
reviewed
Jul 30, 2025
Grinnz
approved these changes
Jul 30, 2025
tonycoz
approved these changes
Jul 31, 2025
Previously, a failing stat would return an empty list in list context,
not undef. This can cause surprises in code like:
foo(stat $file); # would call foo() without arguments if stat fails
my %hash = (
stat => stat($file),
# Odd number of elements in hash assignment if stat fails
);
That is, show how to access File::stat::stat without overriding anything and how to access CORE::stat despite overriding stat.
Previously, the POD used a mix of 1-space and 4-space indents. Also, hyperlink stat(2) and Class::Struct.
Most lines in these files used spaces for indentation, but a few of them still had tabs. Keep things consistent by using spaces everywhere.
I'm not sure why the "unexported and undocumented populate() function" had to be mentioned here. The more straightforward `stat(\*_)` syntax works on all perl versions back to (at least) 5.8.9 and is compatible with CORE::stat, too.
mauke
force-pushed
the
file-stat-cleanup
branch
from
8762b05 to
1335ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #23508, here are some bigger changes:
File::stat::statandFile::stat::lstatalways return a scalar, even in list context. In particular, the failure case now always returnsundef, not the empty list.CORE::stat(andCORE::lstat) behavior of checking$_if no arguments are given.stat(\*_)syntax to reuse previous stat results.