Support SameSite cookie attribute. #1217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs careful testing. Also, we probably don't want to set the attribute if the user hasn't asked us to; at present the code will set it to 'None' - which, while that's what a standards-compliant browser will interpret the lack of a SameSite attribute as, it's probably still better to only send it if we were told to, and omit it if not?
joshrabinowitz
added a commit
to joshrabinowitz/Dancer
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs careful testing.
Also, we probably don't want to set the attribute if the user hasn't asked us to; at present the code will set it to 'None' - which, while
that's what a standards-compliant browser will interpret the lack of a SameSite attribute as, it's probably still better to only send it if we were told to, and omit it if not?