Add new sftp environment variables #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SFTP service needs some additional environment variables to be populated, as a result of some recent changes to how refresh tokens are used to generate auth tokens [1]. A few of these vriables are redundant [2], and that's why we use the same "source" variable to map them as late as possible in the provisioning. Eventually if the redundancy is removed from the sftp service we'll want to update the provisioner to stop populating the obsolete copies. Issue #138 [1] PermanentOrg/sftp-service#192 [2] PermanentOrg/sftp-service#289
cecilia-donnelly
approved these changes
Oct 26, 2023
|
I meant to include this in the PR description but just to have it written: the associated new github secrets have been populated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR populates the necessary environment variables for the sftp service.
Resolves #138
Related to PermanentOrg/sftp-service#289