-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per 9756 update archive type onboarding screen #439
Per 9756 update archive type onboarding screen #439
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
- Coverage 42.40% 42.38% -0.03%
==========================================
Files 346 346
Lines 10836 10837 +1
Branches 1768 1769 +1
==========================================
- Hits 4595 4593 -2
- Misses 6217 6220 +3
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small bits of initial feedback before we pass it to QA.
@@ -9,7 +10,7 @@ | |||
|
|||
border-radius: 12px; | |||
border: 1px solid rgba(255, 255, 255, 0.16); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border: 1px solid rgba(255, 255, 255, 0.16); | |
border: none; |
I think one of the things requested in the ticket is to remove a weird orange line that appears near the component. It seems like this change gets rid of that.
@@ -5,8 +5,8 @@ | |||
background: #fff; | |||
border-radius: 12px 12px 0px 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-radius: 12px 12px 0px 0px; | |
border-radius: 12px; |
The design for this dialog actually changed at some point after it was initially implemented. It is now not flush with the bottom of the screen, so I believe we have a consistent border radius now.
if (this.tag) { | ||
this.buttonText = generateElementText( | ||
this.tag, | ||
archiveOptionsWithArticle, | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov is pointing out that this is missing coverage. It would be nice to write a test that renders the component with the tag
input provided.
src/app/onboarding/components/glam/archive-type-select/archive-type-select.component.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeslikesolo can't do much bolder, this is tthe only bold font that i have :( |
@crisnicandrei could you confirm what font you're using for onboarding? The bold/not bold has been hard to see across onboarding and I just want to check we're using the right font. If the font is correct, could you coordinate with Tibi about why it's not looking like the design? @yeslikesolo once Andrei has checked that, could you re-review this? |
@k8lyn6 @yeslikesolo I think I got it right this time. Can you please recheck? It was Usual, but I had to use the extra bold instead |
8dfb34d
to
e059254
Compare
Design changes for the archive type select screen.
@yeslikesolo I am missing some texts for the "Other" and "I'm not sure yet" so we keep the header text format please!