PER-10194-make phone unverified #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 45.01% 45.12% +0.11%
==========================================
Files 370 370
Lines 11313 11314 +1
Branches 1866 1867 +1
==========================================
+ Hits 5092 5106 +14
+ Misses 6048 6033 -15
- Partials 173 175 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crisnicandrei
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
2 times, most recently
from
1b88d1d to
5a859f4
Compare
crisnicandrei
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
from
5a859f4 to
2fb90e3
Compare
|
@slifty rebased this |
crisnicandrei
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
from
2fb90e3 to
12d6478
Compare
crisnicandrei
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
from
12d6478 to
88fe7b3
Compare
|
I have found some issues with this flow, but are BE related, so I created a new bug for it: https://permanent.atlassian.net/browse/PER-10318 From my point of view, the FE part looks good, so I would recommend merging. @cecilia-donnelly Could you please have a look at the bug I added and if my approach seems correct to you, do you think we could merge this PR? |
aasandei-vsp
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
from
88fe7b3 to
51835b3
Compare
When removing the phone number, set the status to unverified
aasandei-vsp
force-pushed
the
PER-10194-clearing-phone-should-make-it-unverified
branch
from
51835b3 to
1be2606
Compare
aasandei-vsp
approved these changes
Oct 8, 2025
cecilia-donnelly
deleted the
PER-10194-clearing-phone-should-make-it-unverified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing the phone number, set the status to unverified
Steps to test: