PER-10229-fix-archive-invite-dropdown #618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 44.77% 44.85% +0.08%
==========================================
Files 371 371
Lines 11294 11298 +4
Branches 1850 1850
==========================================
+ Hits 5057 5068 +11
+ Misses 6067 6062 -5
+ Partials 170 168 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crisnicandrei
force-pushed
the
PER-10229-fix-archive-member-invite-dropdown
branch
2 times, most recently
from
1209630 to
88fe97e
Compare
|
I am rebasing on main, which includes a lot of indentation/linting fixes, and I want to keep track of the original commit hash in case I need to get back to it: 88fe97e |
Implemented a workaround to allow a custom div/button to toggle the open state of a native <select> by adjusting its size attribute. This mimics dropdown behavior without relying on unsupported programmatic opening. Also handles closing on selection.
cecilia-donnelly
force-pushed
the
PER-10229-fix-archive-member-invite-dropdown
branch
from
88fe97e to
f9ffad2
Compare
cecilia-donnelly
requested review from
aasandei-vsp
and removed request for
slifty
|
@aasandei-vsp, no need to look at this yet - I broke it while rebasing and haven't figured out how to fix yet. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a workaround to allow a custom div/button to toggle the open state of a native by adjusting its size attribute. This mimics dropdown behavior without relying on unsupported programmatic opening. Also handles closing on selection. Steps to test: Go to archive members Go to add Click on the role The dropdown should open