-
Notifications
You must be signed in to change notification settings - Fork 1
Add skip step buttons to onboarding #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
454f017
to
2ab7b3f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 45.16% 45.23% +0.07%
==========================================
Files 370 370
Lines 11284 11290 +6
Branches 1860 1860
==========================================
+ Hits 5096 5107 +11
+ Misses 6013 6008 -5
Partials 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ab7b3f
to
08bb34a
Compare
@crisnicandrei this also has conflicts -- could you rebase? I'll get to review today! |
08bb34a
to
195b14c
Compare
@slifty rebased |
195b14c
to
fdce397
Compare
fdce397
to
fed88d4
Compare
fed88d4
to
40fbab0
Compare
fa50648
to
d39a83e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this locally and also had a look at the code, from my point of view, it's good for merging.
@cecilia-donnelly Do you think we could merge it?
Steps to test: