Skip to content

Conversation

crisnicandrei
Copy link
Contributor

@crisnicandrei crisnicandrei commented Aug 5, 2025

Steps to test:

  1. Create a new account
  2. Get to the surveys
  3. Click the "Skip this step" button
  4. The step should be skipped succesfully

@crisnicandrei crisnicandrei force-pushed the per-10228-oboarding-skip-step-button branch 2 times, most recently from 454f017 to 2ab7b3f Compare August 5, 2025 13:09
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.23%. Comparing base (2e200fa) to head (d39a83e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   45.16%   45.23%   +0.07%     
==========================================
  Files         370      370              
  Lines       11284    11290       +6     
  Branches     1860     1860              
==========================================
+ Hits         5096     5107      +11     
+ Misses       6013     6008       -5     
  Partials      175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crisnicandrei crisnicandrei force-pushed the per-10228-oboarding-skip-step-button branch from 2ab7b3f to 08bb34a Compare August 5, 2025 13:31
@slifty
Copy link
Contributor

slifty commented Aug 21, 2025

@crisnicandrei this also has conflicts -- could you rebase? I'll get to review today!

@crisnicandrei crisnicandrei force-pushed the per-10228-oboarding-skip-step-button branch from 08bb34a to 195b14c Compare August 21, 2025 14:45
@crisnicandrei
Copy link
Contributor Author

@slifty rebased

@crisnicandrei crisnicandrei force-pushed the per-10228-oboarding-skip-step-button branch from 195b14c to fdce397 Compare August 21, 2025 16:31
@crisnicandrei crisnicandrei force-pushed the per-10228-oboarding-skip-step-button branch from fdce397 to fed88d4 Compare September 2, 2025 16:37
@cecilia-donnelly cecilia-donnelly requested review from aasandei-vsp and removed request for slifty September 5, 2025 18:51
@cecilia-donnelly cecilia-donnelly force-pushed the per-10228-oboarding-skip-step-button branch from fed88d4 to 40fbab0 Compare September 8, 2025 21:06
@aasandei-vsp aasandei-vsp force-pushed the per-10228-oboarding-skip-step-button branch from fa50648 to d39a83e Compare October 7, 2025 13:04
Copy link
Contributor

@aasandei-vsp aasandei-vsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally and also had a look at the code, from my point of view, it's good for merging.

@cecilia-donnelly Do you think we could merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants