[PER-10275] Fixed archive selector modal available archives list

[aasandei-vsp]

BUG: https://permanent.atlassian.net/browse/PER-10275

OBSERVATION: This bug will only fix the list of archives, but there are other bugs that will affect this flow. Will add those as new issues and prioritize them in the backlog.

STEPS TO TEST:

1. Create account or sign in to account A
2. Upload a file
3. Create a share link for the uploaded file
4. Copy the link
5. Open a new browser instance
6. Create or sign in to a different account B
7. Create multiple new archives for account B
8. Paste the link in the browser where the account B is signed in
9. The share link preview will appear, click the "Accept Share" button

EXPECTED RESULT:
A modal should appear, with a list of the archives from account B.
OBSERVATION:
The currently selected archive for account B should not be in the list.

I have created this video that replicates the steps to test(can only view the video in Chrome Browser):
show-archives-in-archive-selector.webm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.34%. Comparing base (1be2606) to head (ffa944a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   45.12%   45.34%   +0.21%     
==========================================
  Files         370      371       +1     
  Lines       11314    11317       +3     
  Branches     1867     1866       -1     
==========================================
+ Hits         5106     5132      +26     
+ Misses       6033     6009      -24     
- Partials      175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cecilia-donnelly]

This looks good - I see the other issues you mentioned that are outside the scope of this ticket, mainly the other modal opening behind this one.

It also looks to me like you moved this from core to shared, which gives me a little pause because generally the goal had been to move things out of shared, since that module is so big. Can you tell me a little about your thinking there?

[aasandei-vsp]

This looks good - I see the other issues you mentioned that are outside the scope of this ticket, mainly the other modal opening behind this one.

It also looks to me like you moved this from core to shared, which gives me a little pause because generally the goal had been to move things out of shared, since that module is so big. Can you tell me a little about your thinking there?

I wasn't aware we're trying to move away from 'shared'. I moved it here because part of the bug was that the archive switcher was importing most of its components from shared and they were not rendering(tangled module imports).

I can try and move it to a more relevant module, but from my point of view, that wouldn't be core, maybe 'shares'?
This would also be a big change, because multiple components would need to be moved there.

I could also try to just move this specific component and in time to try and move all relevant component to 'shares'.

[aasandei-vsp]

@omnignorant @cecilia-donnelly I have added the steps to follow in order to test this bug and also a video in the description of this PR, but if you need more information, please let me know.