Skip to content

Conversation

aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Oct 2, 2025

https://permanent.atlassian.net/browse/PER-10311

!!!! This branch is actually based on PR: #727 so DO NOT MERGE.
I made it into a draft, especially because it would be hard to review the changes specific to this PR.

It is worth mentioning that this PR is way smaller than I anticipated. The reason for it is that when I separated the stories into logged in and anonymous users, I made the assumption that for logged in users I will not need to use the new stela endpoints to retrieve the details for the preview, which proved to be wrong.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 48.21429% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.61%. Comparing base (1e8adef) to head (e450fcc).

Files with missing lines Patch % Lines
src/app/shared/services/api/folder.repo.ts 10.00% 27 Missing ⚠️
...er/components/file-viewer/file-viewer.component.ts 52.63% 7 Missing and 2 partials ⚠️
...ponents/file-list-item/file-list-item.component.ts 42.85% 8 Missing ⚠️
src/app/shared/services/api/record.repo.ts 46.15% 7 Missing ⚠️
...rowser/components/file-list/file-list.component.ts 20.00% 4 Missing ⚠️
...omponents/share-preview/share-preview.component.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   45.18%   46.61%   +1.43%     
==========================================
  Files         370      371       +1     
  Lines       11284    11369      +85     
  Branches     1860     1879      +19     
==========================================
+ Hits         5099     5300     +201     
+ Misses       6013     5881     -132     
- Partials      172      188      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp marked this pull request as draft October 2, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant