Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fixed step numbers being out and made PICS F00(EnergyManagement) / F01(TankPercentage) to be more in line with the test plan.
  • Loading branch information
jamesharrow authored Oct 3, 2024
1 parent ed50c40 commit 4a57128
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/python_testing/TC_EWATERHTR_2_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,22 +99,22 @@ async def test_TC_EWATERHTR_2_1(self):
if em_supported:
value = await self.read_whm_attribute_expect_success(attribute="TankVolume")
else:
logging.info("Skipping step 4 as PICS.EWATERHTR.EM not supported")
logging.info("Skipping step 5 as PICS.EWATERHTR.F00(EnergyManagement) not supported")

self.step("6")
if em_supported:
value = await self.read_whm_attribute_expect_success(attribute="EstimatedHeatRequired")
asserts.assert_greater_equal(value, 0, f"Unexpected EstimatedHeatRequired value - expected {value} >= 0")
else:
logging.info("Skipping step 5 as PICS.EWATERHTR.EM not supported")
logging.info("Skipping step 6 as PICS.EWATERHTR.F00(EnergyManagement) not supported")

self.step("7")
if tp_supported:
value = await self.read_whm_attribute_expect_success(attribute="TankPercentage")
asserts.assert_greater_equal(value, 0, f"Unexpected TankPercentage value - expected {value} >= 0")
asserts.assert_less_equal(value, 100, f"Unexpected TankPercentage value - expected {value} <= 100")
else:
logging.info("Skipping step 6 as PICS.EWATERHTR.TP not supported")
logging.info("Skipping step 7 as PICS.EWATERHTR.F01(TankPercenage) not supported")

self.step("8")
boost_state = await self.read_whm_attribute_expect_success(attribute="BoostState")
Expand Down

0 comments on commit 4a57128

Please sign in to comment.