Add support for Galileo #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GSA sentence for multi-constellation
In sentences_to_dataframes() check for all GSA sentences, not only non-merged ones
Error occurs with this data (column size mismatch), so needs to be fixed
$GPGSV,4,1,13,02,52,170,26,04,09,307,24,09,04,338,12,16,26,295,20,1*62
$GPGSV,4,2,13,18,50,161,25,26,63,288,25,27,04,251,20,28,33,201,29,1*6E
$GPGSV,4,3,13,29,47,064,22,31,48,226,27,05,18,063,,20,14,037,,1*6C
$GPGSV,4,4,13,25,18,120,,1*5B
$GPGSV,1,1,03,09,04,338,,26,63,288,,27,04,251,,8*5F
Last sentence contains duplicates of SVs in first 4
Remove debug test data to not clutter test_data foder Signed-off-by: Emiel Demeestere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes since commit f0f5fa8:
Rearranging imports and adding note about overriding print() (2022-03-25 11:17:58 -0600)
are available in the Git repository at:
https://github.com/emiedmee/nmea_data_convert add-galileo
for you to fetch changes up to 9e61200:
Fix column size mismatch, but keep code to catch this except (2023-04-22 16:20:10 +0200)
I've been working with the Quectel RM500Q-GL module, which has a GNSS engine and can output NMEA sentences.
I found your project and it almost fit my needs, except that I'm not using GLONASS but a combination of GPS and Galileo.
So I've decided to add Galileo support next to GPS and GLONASS in your project.
This has been tested with several files containing various states of NMEA sentences and all issues, including issues in the original code, should be fixed with this PR.
I've also made all the code comply more with Python coding guidlines using linters, etc.
I hope you like my work!
closes #9
Emiel Demeestere (20):
Signed-off-by: Emiel Demeestere [email protected]