Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyOpenSci Initial Updates and Upgrades #205

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Conversation

robelgeda
Copy link
Contributor

@robelgeda robelgeda commented Feb 27, 2024

List of updates based on pyOpenSci review

  • The package should install without the use of requirement.txt:
    • Matplotlib was missing, I have added it.
    • New versions of astropy no longer need update_default_config. I have removed this function call for people using pip to install.
  • Add zenodo badge (I see one on the Citing and Credits) page in docs to README.md
  • Clean up docstrings in models.py
  • Update pip install instructions
  • Clean up ci_test.yml

@robelgeda robelgeda closed this Feb 27, 2024
@robelgeda robelgeda reopened this Feb 27, 2024
@robelgeda robelgeda merged commit e5d06fd into PetroFit:main Feb 27, 2024
8 checks passed
@SterlingYM
Copy link

These changes seem to solve some problems with the compatibility of the up-to-date Astropy version when tested with a clone of the current main branch, but the latest release of Petrofit on PyPI is outdated and does not include these changes. Could you release the current main branch and update the pip-installable version? This will help quite a lot when using Petrofit as a requirement for other packages. Thanks!

@robelgeda
Copy link
Contributor Author

Absolutely! I will work on python compatibility issues next two weeks and release whatever I we have ready. Thank you for letting us know!!

@robelgeda robelgeda mentioned this pull request Aug 16, 2024
@robelgeda
Copy link
Contributor Author

@SterlingYM I have released a minor version with the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants