pyOpenSci Initial Updates and Upgrades #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes seem to solve some problems with the compatibility of the up-to-date Astropy version when tested with a clone of the current main branch, but the latest release of Petrofit on PyPI is outdated and does not include these changes. Could you release the current main branch and update the pip-installable version? This will help quite a lot when using Petrofit as a requirement for other packages. Thanks! |
|
Absolutely! I will work on python compatibility issues next two weeks and release whatever I we have ready. Thank you for letting us know!! |
Merged
|
@SterlingYM I have released a minor version with the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of updates based on pyOpenSci review
requirement.txt:update_default_config. I have removed this function call for people using pip to install.models.pyci_test.yml