Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pherry: faster header sync #1521

Merged
merged 4 commits into from
Feb 22, 2024
Merged

pherry: faster header sync #1521

merged 4 commits into from
Feb 22, 2024

Conversation

nanometerzhu
Copy link
Contributor

No description provided.

@nanometerzhu nanometerzhu marked this pull request as ready for review January 29, 2024 05:46
@nanometerzhu nanometerzhu force-pushed the pherry-sync-fewer-data branch from c5eae53 to cb1ff0e Compare January 29, 2024 05:54
kvinwang
kvinwang reviewed Jan 31, 2024
View reviewed changes
standalone/pherry/src/lib.rs Outdated Show resolved Hide resolved
standalone/pherry/src/lib.rs Outdated Show resolved Hide resolved
standalone/pherry/src/types.rs Outdated Show resolved Hide resolved
standalone/pherry/src/lib.rs Show resolved Hide resolved
@kvinwang
Copy link
Collaborator

Error in the e2e log:

[2024-01-30T22:01:16.516650Z INFO  pherry] bridge() exited with error: Rpc error: RPC error: RPC call failed: ErrorObject { code: ServerError(4), message: "GRANDPA prove finality rpc failed: Block not covered by authority set changes", data: None }
    
    Caused by:
        RPC error: RPC call failed: ErrorObject { code: ServerError(4), message: "GRANDPA prove finality rpc failed: Block not covered by authority set changes", data: None }

@nanometerzhu nanometerzhu force-pushed the pherry-sync-fewer-data branch from cb1ff0e to 2732752 Compare February 7, 2024 01:05
@nanometerzhu nanometerzhu changed the title pherry: faster sync pherry: faster header sync Feb 7, 2024
@nanometerzhu nanometerzhu force-pushed the pherry-sync-fewer-data branch from 61ef14e to fcde071 Compare February 22, 2024 01:13
kvinwang
kvinwang approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One more question: Should the patch of sc-consensus-grandpa be send upstream?

@nanometerzhu
Copy link
Contributor Author

LGTM. One more question: Should the patch of sc-consensus-grandpa be send upstream?

Yes, I will create an issue and request merge.

@nanometerzhu
pherry: faster header sync
db5d470 
1. Only work on new pruntime which reading justification from headers.
2. Simplify the syncing logical.
@nanometerzhu
do not sync before the chain finalizing first block
344c7b4
@nanometerzhu
pRuntime management test: verify at least sync 1 header
b10a48e
@nanometerzhu
patch sc-consensus-grandpa to fix CI
87fb350 
issue: finality_proof API does not work before the first authority set change
@nanometerzhu nanometerzhu force-pushed the pherry-sync-fewer-data branch from fcde071 to 87fb350 Compare February 22, 2024 05:42
@nanometerzhu nanometerzhu merged commit c264c98 into master Feb 22, 2024
8 checks passed
@nanometerzhu nanometerzhu deleted the pherry-sync-fewer-data branch February 22, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvinwang kvinwang kvinwang approved these changes

@h4x3rotab h4x3rotab Awaiting requested review from h4x3rotab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanometerzhu @kvinwang