Skip to content

MAINT: Rename process_debye_gruneisen to process in DebyeGruneisen class #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nhew1994
Copy link
Collaborator

  • Modified test.yaml to run on all branches

@Copilot Copilot AI review requested due to automatic review settings May 18, 2025 14:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the method process_debye_gruneisen to process in the DebyeGruneisen class and updates related tests and configuration files.

  • Renames the method in dfttk/debye/debye_gruneisen.py and updates its invocations in tests/debye.py and dfttk/config.py.
  • Modifies the GitHub workflow in .github/workflows/test.yaml to run tests on all branches.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/test_debye.py Updated the method invocation from process_debye_gruneisen to process.
dfttk/debye/debye_gruneisen.py Renamed the method and maintained consistency with the overall code style.
dfttk/config.py Adjusted the method call to use the new name.
.github/workflows/test.yaml Removed branch filters so that tests run on all branches.
Comments suppressed due to low confidence (1)

.github/workflows/test.yaml:4

  • [nitpick] The removal of branch filters will cause tests to run on all branches. Confirm this change is intentional and aligns with your deployment strategy.
push:

@@ -170,7 +170,7 @@ def calculate_heat_capacities(self, debye_temperature: float) -> np.ndarray:
heat_capacities[i] = 3 * self.number_of_atoms * BOLTZMANN_CONSTANT * debye_integrals[i]
return heat_capacities

def process_debye_gruneisen(
def process(
Copy link
Preview

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider updating or adding a docstring for the process() method to reflect the new naming and clarify its functionality.

Copilot uses AI. Check for mistakes.

@nhew1994
Copy link
Collaborator Author

This PR renames the method process_debye_gruneisen to process in the DebyeGruneisen class and updates related tests and configuration files.

Renames the method in dfttk/debye/debye_gruneisen.py and updates its invocations in tests/debye.py and dfttk/config.py.
Modifies the GitHub workflow in .github/workflows/test.yaml to run tests on all branches.

@nhew1994 nhew1994 closed this May 18, 2025
@nhew1994 nhew1994 deleted the debye_refactor branch May 18, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant