This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Get5 0.9 #33
Merged
Get5 0.9 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR fully working at the moment? |
|
Hey, If you're using the branch for 0.9 in get5, yes. However, you may run into errors on every player death right now as it hasn't been implemented in the API yet. Other than that it should. |
|
Thanks! Can you also pick changes from this commit? splewis/get5@5afc25b |
|
That should be irrelevant to this project. This is an extension of get5, and if you want a build that has more changes like that I am currently not able to provide that. You may have to do the rebase locally and make those changes. |
* Uggghh * Update make_release.yml Update make_release.yml Update forwards, change match ID. This may break demo uploads so will have to be tested.
TODO: Test demo's to ensure they are being uploaded and matchID exists on demo upload.
Update release to get correct submodules.
Should compile and work on get5 0.9 now.
PhlexPlexico
force-pushed
the
get5-update
branch
from
82cf16d
to
c631ff9
Compare
Add in support message as well that is toggleable, explained in the README.
PhlexPlexico
force-pushed
the
get5-update
branch
2 times, most recently
from
88426bc
to
0b1f839
Compare
Remove files managed by get5 source control. Remove unsused files Compile for 0.9
PhlexPlexico
force-pushed
the
get5-update
branch
from
0b1f839
to
91067ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to go in conjunction with get5 0.9 to fix some of the headers that are now included, such as the match ID being put into the forwards instead.