Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Insignia Type #1416

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Nov 5, 2024

This isn't a real logic, but more like an interface to make ini edit easier. Previously we have to define insignia by the techno's veterancy, which requires a lot of tags especially if it's for Gunner or using InsigniaFrame(s). This pull request allows you to define an InsigniaType that stores all these data together, so that you can reuse them in different places with one line of code.

In rulesmd.ini:

[InsigniaTypes]
0=SOMEINSIGNIATYPE

[SOMEINSIGNIATYPE]						 ; InsigniaType
Insignia=                                ; filename - excluding the .shp extension
Insignia.Rookie=                         ; filename - excluding the .shp extension
Insignia.Veteran=                        ; filename - excluding the .shp extension
Insignia.Elite=                          ; filename - excluding the .shp extension
InsigniaFrame=-1                         ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.Rookie=-1                  ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.Veteran=-1                 ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.Elite=-1                   ; int, frame of insignia shp (zero-based) or -1 for default

[SOMETECHNO]                             ; TechnoType
InsigniaType=                            ; InsigniaType
InsigniaType.WeaponN=                    ; InsigniaType

An example:

[InsigniaTypes]
0=InsigniaHero

[InsigniaHero]
Insignia.Rookie=herostcr
Insignia.Veteran=herostbr
Insignia.Elite=herostar

[TANY]
InsigniaType=InsigniaHero
IFVMode=15

[VOLKOV]
InsigniaType=InsigniaHero
IFVMode=35

[FV]
InsigniaType.Weapon15=InsigniaHero
InsigniaType.Weapon35=InsigniaHero

@github-actions github-actions bot added the Minor Documentation is not required label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Comment on lines +9 to +10
Promotable<SHPStruct*> Insignia;
Promotable<int> InsigniaFrame;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are other tags not suitable for definition here?

Can you check the MultitagReadable-based templates btw? In PR #1304.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was once thought about Insignia.ShowEnemy, but not really sure if it should be in this.

@Metadorius Metadorius self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants