Faking Digital Display of Health

[Coronia]

• DigitalDisplay.Health.FakeAtDisguise, if set to true on an InfantryType with Disguise, will use the disguised TechnoType's Strength value as the maximum value of health display. The current value will be displayed as the percentage of its current health multiplies the new maximum value.

In rulesmd.ini:

[SOMETECHNOTYPE]
DigitalDisplay.Health.FakeAtDisguise=true      ; boolean

[github-actions]

Nightly build for this pull request:

• compiled-dll-ee5a4c83e59e396265664c04f9c78d8133474897.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

Code looks mostly good, can be simplified though IMO.

[Coronia]

there's another usage for DigitalDisplay.Health.FakeStrength now: when something has a lot of strength, like 9999999, you may want it to not show that many digits. This tag could scale down the number to a lower value. Ofc you can also do it by making a new techno and use DigitalDisplay.Health.FakeAtDisguise but that's way more complex

regardlessly, it's not bad to give a direct way to set this value since there'll always be cases that you want digital display to show something else from a given value, not to mention that only infantry can disguise as another so far

[Metadorius]

there's another usage for DigitalDisplay.Health.FakeStrength now: when something has a lot of strength, like 9999999, you may want it to not show that many digits. This tag could scale down the number to a lower value. Ofc you can also do it by making a new techno and use DigitalDisplay.Health.FakeAtDisguise but that's way more complex

I think that's better to be handled using a display coefficient, like when people use big numbers like 1 500 000 HP instead of 1 500 HP on everything just to have more precision on game's calculations, no?

[Coronia]

I can agree that coefficient on display type is a better approach than setting a fake value on techno type, also ValueScaleDivisor has been introduced already. Hence, I would only keep DigitalDisplay.Health.FakeAtDisguise since this is a special case, and remove the other tags