Damaged Unit image #1446
Damaged Unit image #1446
Conversation
2 new sections for image changes
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
is there possibly to specify shp filename instead of unittype ? |
|
That would be awesome, but it's harder to implement. Instead, this one using same method as Ares' |
|
And, in theory, it also should work for shp units, but I couldn't implement for the terror drone, so probably, I'm missing something. |
|
Maybe |
I think |
| } | ||
| } | ||
|
|
||
| R->EAX(pThis->WalkedFramesSoFar); |
There was a problem hiding this comment.
Just return 0 and the overlapped assembly will be recovered. As far as I know, you only need to restore the assembly manually if you overlapped some jump code, like jz or jmp.
| @@ -466,6 +466,20 @@ int TechnoExt::ExtData::GetAttachedEffectCumulativeCount(AttachEffectTypeClass* | |||
| return foundCount; | |||
| } | |||
|
|
|||
| UnitTypeClass* TechnoExt::ExtData::GetUnitTypeExtra(bool isRedHP) const { | |||
There was a problem hiding this comment.
Maybe you should move the health checks into the extra function. Thus others can reuse this function if they want to further expand the image.
This changes unit's image if it's health is in ConditionYellow or ConditionRed
[SOMEUNIT] ; UnitType
DamagedImage.ConditionYellow= ; UnitType entry
DamagedImage.ConditionRed= ; UnitType entry
WaterDamagedImage.ConditionYellow= ; UnitType entry
WaterDamagedImage.ConditionRed= ; UnitType entry