Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Total War: Rome II, script cleanup #1184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Total War: Rome II, script cleanup #1184

wants to merge 3 commits into from

Conversation

Zemogiter
Copy link
Contributor

@Zemogiter Zemogiter commented Jan 5, 2020 •
edited
Loading

Description

fix #1179

What works

Steam and verb installation

What was not tested

The game itself bc I don't have it.

Test

  • Operating system (and linux kernel version): Ubuntu 19.10
  • Hardware (GPU/CPU): GTX 1080 ti, i7-7700K

Ready for review

  • Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • json-align and eslint run according to the documentation.
  • Codacy and travis checked.

@Zemogiter
Copy link
Contributor Author

Ready for review.

plata
plata reviewed Jan 5, 2020
View reviewed changes
Applications/Games/Total War Rome II/Steam/script.js
@@ -13,6 +13,7 @@ new SteamScript()
.appId(214950)
.wineVersion(getLatestStagingVersion)
.wineDistribution("staging")
.environment('{"__GL_THREADED_OPTIMIZATIONS": "1", "LD_PRELOAD" = "libpthread.so.0 libGL.so.1"}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a comment mentioning this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/Applications/Games/Total War Rome II/Steam/script.js

Line 28 in 3a26096

//N.B. : maybe need "LD_PRELOAD="libpthread.so.0 libGL.so.1" __GL_THREADED_OPTIMIZATIONS=1" for terrain glitches (OpenGL Mode)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh. I don't feel comfortable adding it in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 do you think we can add this line to script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if someone could test it IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 can you do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImperatorS79 ImperatorS79 ImperatorS79 left review comments

@madoar madoar madoar left review comments

@plata plata plata requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "Total War: ROME 2" script
4 participants
@Zemogiter @plata @madoar @ImperatorS79