Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Total War: Rome II, script cleanup #1184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Total War: Rome II, script cleanup #1184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08a2e1f
Update script.js
Zemogiter Jan 5, 2020
f634320
Update script.js
Zemogiter Jan 5, 2020
913702a
Update script.js
Zemogiter Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Applications/Games/Total War Rome II/Steam/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ new SteamScript()
.appId(214950)
.wineVersion(getLatestStagingVersion)
.wineDistribution("staging")
.environment('{"__GL_THREADED_OPTIMIZATIONS": "1", "LD_PRELOAD" = "libpthread.so.0 libGL.so.1"}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a comment mentioning this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/Applications/Games/Total War Rome II/Steam/script.js

Line 28 in 3a26096

//N.B. : maybe need "LD_PRELOAD="libpthread.so.0 libGL.so.1" __GL_THREADED_OPTIMIZATIONS=1" for terrain glitches (OpenGL Mode)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh. I don't feel comfortable adding it in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 do you think we can add this line to script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if someone could test it IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 can you do it?

.postInstall((wine, wizard) => {
new D3DX9(wine).go();
new Vcrun2005(wine).go();
Expand All @@ -21,9 +22,7 @@ new SteamScript()

wizard.message(
tr(
"If you are experiencing issues with game (e.g. it crashes at start or rendering is broken), you can try to enable de OpenGL renderer, by modifying :\n\n gfx_device_type to 2\n\n in the {0}/drive_c/users/USERNAME/Application Data/The Creative Assembly/Rome2/scripts/preferences_script.txt",
wine.prefixDirectory
"If you are experiencing issues with game (e.g. it crashes at start or rendering is broken), you can try to enable de OpenGL renderer, by modifying :\n\n gfx_device_type to 2\n\n in the wine.prefixDirectory()/drive_c/users/USERNAME/Application Data/The Creative Assembly/Rome2/scripts/preferences_script.txt",
)
);
//N.B. : maybe need "LD_PRELOAD="libpthread.so.0 libGL.so.1" __GL_THREADED_OPTIMIZATIONS=1" for terrain glitches (OpenGL Mode)
});