Fix Wine plugin "Override DLL" #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zemogiter please try. |
madoar
approved these changes
Dec 23, 2019
| @@ -3,23 +3,21 @@ const Regedit = include("engines.wine.plugins.regedit"); | |||
| module.default = class OverrideDLL { | |||
| constructor(wine) { | |||
| this.wine = wine; | |||
| this.modes = {}; | |||
| this.modes = new Map(); | |||
There was a problem hiding this comment.
Indeed a Map is a better choice here.
|
|
||
| return this; | ||
| } | ||
|
|
||
| go() { | ||
| let regeditFileContent = `REGEDIT4\n\n[HKEY_CURRENT_USER\\Software\\Wine\\DllOverrides]\n`; | ||
|
|
||
| Object.entries(this.modes) | ||
| .map(([mode, libraries]) => libraries.map(library => [library, mode])) |
There was a problem hiding this comment.
Just as a sidenot, I think the following change would be enough to fix the issue but I agree that your code is more readable:
.flatMap(([mode, libraries]) => libraries.map(library => [library, mode]))
|
@plata thanks now it works |
This was referenced Dec 24, 2019
This was referenced Dec 24, 2019
Draft
petermetz
pushed a commit
to petermetz/scripts
that referenced
this pull request
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1151