-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera disconnected + stream normalization improvements #1701
Conversation
If I try to "start calibration", I don't see the processed stream (it almost seems to freeze). But if I manually navigate to http://10.17.36.12:1181/stream.mjpg and http://10.17.36.12:1182/stream.mjpg , I do. And if I reload the webpage, I see it too. |
Odd, I can't seem to reproduce this, is it device/camera specific? Quickly tested on vite dev run with arducam 9281 |
I also cannot reproduce on my opi. |
Images are before and after comparison.
Does the following:
Fixes logic for disconnected cameras in camera matching view to properly indicate the actual status of the camera. Previously disconnected cameras were falsely flagged as mismatches.
Sorts camera modules by (active, connected) / mismatch -> (active, disconnected) -> deactivated -> unassigned
Massively (as far as I can tell) improves camera stream height normalization logic in camera matching view, and guts all the unnecessary logic previously used to accomplish this
(verification that it works, for me at least)
New stream spinner to make camera stream size normalization work nicely - needed matching or transparent background
P.S. camera lost image, don't think I didn't see you...