Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] Less structures exposed in Cython #15

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

blefaudeux
Copy link
Contributor

Keeping more structures internal

  • no benefit in exposing them to python and augments the cython code
  • we're about to make this more modular, to expose loading from local folders or object storage, so anything DB related is not generic enough anyway

@blefaudeux
Copy link
Contributor Author

cc @DeltaEvo, waiting for the CI but instaland after that, feel free to chime in anytime

@blefaudeux blefaudeux merged commit 83bb17c into main Oct 6, 2024
2 checks passed
@blefaudeux blefaudeux deleted the ben/less_public_fields branch November 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant