[refactor] Yet another small set of arch improvements + adding a lot of python tests #29
+353
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blefaudeux
commented
Nov 12, 2024
•
blefaudeux
commented
- Remove SetDefaults() but expose Get**Configs() instead, easier to use / more foolproof and fewer lines
- Adding a bunch of end to end tests on the python side to pin down the behavior vs. internal version
- Better defaults
- Better handling of the json configs (undefined fields get defaulted)
- "Generator" <> "Source", guess what that it was more explicit
blefaudeux
force-pushed
the
ben/ml-2346-move-everything-to-the-public-datago
branch
12 times, most recently
from
2e36eb3 to
be98434
Compare
blefaudeux
force-pushed
the
ben/ml-2346-move-everything-to-the-public-datago
branch
from
be98434 to
d1cd2d8
Compare
blefaudeux
changed the title
blefaudeux
commented
Nov 13, 2024
| @@ -0,0 +1,186 @@ | |||
| from datago import datago | |||
There was a problem hiding this comment.
these are new from this PR, still missing a few from the internal codebase but almost there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.