-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #64
Open
dconco
wants to merge
21
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lides\Core and improve test script execution
… composer scripts with post-install command
…rove error handling for array parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
Router
andCore
components of the PhpSlides application, focusing on namespace refactoring, case sensitivity handling, and workflow improvements. The most important changes include namespace updates, case sensitivity handling in routing, and modifications to GitHub workflows.Namespace Refactoring:
PhpSlides\Src
toPhpSlides\Core
across multiple files includingRouter/MapRoute.php
,Router/Route.php
,Router/view.php
,src/Bootstrap/App.php
,src/Cache/Cache.php
,src/Config/config.php
, and various controller files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Case Sensitivity Handling:
caseSensitive
method inRouter/Route.php
and updating thematch
andmatch_routing
methods inRouter/MapRoute.php
to consider case sensitivity. [1] [2] [3]GitHub Workflows:
.github/workflows/release.yml
and.github/workflows/tests.yml
for better clarity. [1] [2]Push changes to main
job in.github/workflows/tests.yml
to use a different approach for merging and pushing changes.Additional Changes:
composer.json
andphpunit.xml
files to reflect new directory structures and autoload configurations. [1] [2]src/Cache/Cache.php
to be static and updated theclear
andclearHotReload
methods accordingly. [1] [2]