Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial update on SBP-M1 review #23

Merged
merged 21 commits into from
Sep 28, 2023
Merged

Partial update on SBP-M1 review #23

merged 21 commits into from
Sep 28, 2023

Conversation

Ekaanth
Copy link
Contributor

@Ekaanth Ekaanth commented Sep 10, 2023

No description provided.

@Ekaanth Ekaanth requested a review from khssnv September 10, 2023 12:13
@Ekaanth
Copy link
Contributor Author

Ekaanth commented Sep 26, 2023

can we remove the comments here? @khssnv

@khssnv
Copy link
Member

khssnv commented Sep 26, 2023

@Ekaanth, I'll remove them one by one updating things as recommended or preserving your updates from 0055edd.

khssnv added 15 commits September 26, 2023 20:44
@khssnv
Set project version to 0.1.0
5362e92 
Remove reviewer's comments about resetting the version.
@khssnv
Update crates description from 0055edd
cf716f5 
Remove reviewer's comments about crates description update.
@khssnv
Remove reviewer's comments about the homepage
a84a73a 
Homepage URL was added by 0055edd.
@khssnv
Add repository URL in workspace Cargo.toml
b889fa5 
Remove reviewer's comments about updating repository URL.
@khssnv
Add authors and edition to workspace Cargo.toml
0e5b3f2 
Remove reviewer's comments on authors sections.
@khssnv
Update Rust compiler version
f176356 
This version is used for Polkadot v1.0.0 release.

Remove reviewer's comment on toolchain version.
@khssnv
Update clap and futures dependencies
235cb15 
Remove reviewer's comment on clap version update.
@khssnv
Update node impl name
c624945 
Remove reviewer's comment on updating the node impl name.
@khssnv
Remove reviewer's comment on updating support URL
7fcbb1c 
Support URL already set by 0055edd.
@khssnv
Update scale-info version
e288508 
Remove reviewer's comment on updating the scale-info version.
@khssnv
Remove reviewer's comments about Cargo.toml format
b82109b
@khssnv
Autoformat and sort items in manifest files
1fac9ca
@khssnv
Fix number of decimals in the smallest unit
0b1c501
@khssnv
Rename currency unit to MQTY
cf4d4ac 
Remove reviewer's comment about the currency unit name.
@khssnv
Use renamed currency units replacing old ones
cdd42f5
@khssnv khssnv changed the title SBP1-initial review update Partial update on SBP-M1 review Sep 28, 2023
Ekaanth
Ekaanth commented Sep 28, 2023
View reviewed changes
node/Cargo.toml Outdated Show resolved Hide resolved
@khssnv khssnv merged commit 9f55b9c into develop Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khssnv khssnv Awaiting requested review from khssnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ekaanth @khssnv