Revert when endpoint not found (#182)

Pi-Squared-Inc · Nov 7, 2024 · 82e60d6 · 82e60d6
1 parent 3ba0065
commit 82e60d6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/tests/ulm-with-contract/endpoints.notfound.run b/tests/ulm-with-contract/endpoints.notfound.run
@@ -0,0 +1,17 @@
+push "noEndpoint"; 
+hold_string_from_test_stack; 
+push "uint64";
+hold_list_values_from_test_stack; 
+push 123_u64; 
+hold_list_values_from_test_stack; 
+encode_call_data; 
+
+return_value; 
+mock CallData; 
+
+call_contract 12345;
+return_value;
+check_eq ();
+
+push_status; 
+check_eq 3
diff --git a/ulm-semantics/main/preprocessing/endpoints.md b/ulm-semantics/main/preprocessing/endpoints.md
@@ -178,7 +178,7 @@ module ULM-PREPROCESSING-ENDPOINTS
                         | "ulm"  [token]
                         | "ulmWrap##init"  [token]
                         | "CallData"  [token]
-                        | "EVMC_BAD_JUMP_DESTINATION"  [token]
+                        | "EVMC_REVERT"  [token]
                         | "EVMC_SUCCESS"  [token]
 
     syntax BytesOrError  ::= methodSignature(String, NormalizedFunctionParameterList)  [function, total]
@@ -222,8 +222,7 @@ module ULM-PREPROCESSING-ENDPOINTS
             , bufferId: _:Identifier
             , gas: _:Identifier
             )
-        // TODO: Is this the right kind of error?
-        => :: state_hooks :: setStatus(:: ulm :: EVMC_BAD_JUMP_DESTINATION , .CallParamsList);
+        => :: state_hooks :: setStatus(:: ulm :: EVMC_REVERT , .CallParamsList);
 
     rule signatureToCall
             (... signature: Signature:Identifier