Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove end-of-line spaces #188

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Remove end-of-line spaces #188

merged 1 commit into from
Nov 19, 2024

Conversation

virgil-serbanuta
Copy link
Member

End of line spaces look ugly in git diff. Also, they sometimes generate spurious diffs (e.g. change a line, then change it back, and there may be a diff because the end of line space is no longer there).

@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review November 18, 2024 14:38
@virgil-serbanuta virgil-serbanuta requested review from ACassimiro and yanliu18 and removed request for ACassimiro November 18, 2024 14:38
Copy link
Member

@yanliu18 yanliu18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@virgil-serbanuta virgil-serbanuta merged commit 98f352e into main Nov 19, 2024
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the remove-spaces branch November 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants