Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index a trivial program #2

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Index a trivial program #2

merged 1 commit into from
Aug 19, 2024

Conversation

virgil-serbanuta
Copy link
Member

@virgil-serbanuta virgil-serbanuta commented Aug 14, 2024

The commented rules have no tests yet. I plan to add tests and uncomment them.

The indexing configuration may change and become more complex, but this is a fairly simple thing that would probably work.

@ACassimiro
Copy link
Collaborator

@virgil-serbanuta just as a sanity check, I'm trying to run make build but I'm getting the following error:

> make build
$(which kompile) rust-semantics/rust.md -o .build/rust-kompiled
[Error] Internal: Could not compute least upper bound for rewrite sort.
Possible candidates: [MInt{16}, MInt{64}, MInt{8}, MInt{32}]
  while executing phase "Add sort injections"
make: *** [Makefile:32: .build/rust-kompiled/timestamp] Error 113

Is this related to my K version? Or am I missing any steps that I should do prior to building the project?

@virgil-serbanuta
Copy link
Member Author

@virgil-serbanuta just as a sanity check, I'm trying to run make build but I'm getting the following error:

> make build
$(which kompile) rust-semantics/rust.md -o .build/rust-kompiled
[Error] Internal: Could not compute least upper bound for rewrite sort.
Possible candidates: [MInt{16}, MInt{64}, MInt{8}, MInt{32}]
  while executing phase "Add sort injections"
make: *** [Makefile:32: .build/rust-kompiled/timestamp] Error 113

Is this related to my K version? Or am I missing any steps that I should do prior to building the project?

My guess is that your K needs to be past this commit: runtimeverification/k@7e2efdd

I only checked version 7.1.104, which works for me.

Copy link
Member

@yanliu18 yanliu18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine for me.

However, it will be nice if there is a write up about the purpose of this indexing?

Besides, it will also be good to give references of why this implementation make sense, if there is a reference.
For example, is this Traits section of rust-lang reference used?

@virgil-serbanuta
Copy link
Member Author

Ok, I'll try adding some documentation.

@virgil-serbanuta virgil-serbanuta merged commit a6b7eb7 into main Aug 19, 2024
1 check passed
@virgil-serbanuta virgil-serbanuta deleted the semantics branch August 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants